Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changes to run darwin locally #13

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add changes to run darwin locally #13

merged 2 commits into from
Jan 23, 2025

Conversation

swati354
Copy link
Collaborator

No description provided.

@swati354 swati354 requested a review from vnaren23 January 16, 2025 06:00
rajivml
rajivml approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@rajivml rajivml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good, the corresponding helm charts will also require changes to make them aware of environment variable

@swati354
Copy link
Collaborator Author

changes looks good, the corresponding helm charts will also require changes to make them aware of environment variable

Should this be a part of this pr? And how do I make those changes?

@rajivml rajivml merged commit 711b14f into feature/darwin Jan 23, 2025
1 of 2 checks passed
@rajivml rajivml deleted the swati-darwin branch January 23, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajivml rajivml rajivml approved these changes

@vnaren23 vnaren23 Awaiting requested review from vnaren23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swati354 @rajivml